Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build backtrace in JS_NewError #809

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Build backtrace in JS_NewError #809

merged 1 commit into from
Jan 10, 2025

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Jan 9, 2025

Behave similarly to the constructor since it's expected that a backtrace be created.

@saghul
Build backtrace in JS_NewError
ed8b0e4 
Behave similarly to the constructor since it's expected that a backtrace
be created.
@saghul saghul requested a review from bnoordhuis January 9, 2025 21:59
@saghul
Copy link
Contributor Author

saghul commented Jan 9, 2025

@bnoordhuis PTAL. Not fixing a specific bug here, just noticed while going through some code. WDYT?

bnoordhuis
bnoordhuis approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't hurt, I think?

@saghul saghul mentioned this pull request Jan 10, 2025
Closed
@saghul saghul merged commit c8153fe into master Jan 10, 2025
59 checks passed
@saghul saghul deleted the new-error-backtrace branch January 10, 2025 09:10
@saghul
Copy link
Contributor Author

saghul commented Jan 10, 2025

Hopefully not :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis