feat: spring-driven morph animation for askbar-to-chat transition - #11
Merged
Conversation
Replace the abrupt class-swap transition with a cohesive spring-physics morph: the container bounces open via Framer Motion layout animation, chat content slides down from above, and the input bar glides into position — all driven by a pronounced spring (stiffness 300, damping 20). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace Framer Motion layout transforms with explicit height animation (0 → auto) on ConversationView. Layout transforms used CSS scale which overflowed the native window boundary, causing bottom clipping during the spring overshoot. Height animation grows the chat area via real CSS height changes — no transforms, no clipping, no input bar overlap. The isMorphing ref is set synchronously during render so the spring transition is active on the exact frame where chat mode activates. After 600ms the ref flips to false, switching streaming resizes to instant (duration: 0) to prevent the input bar from lagging behind growing content. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove morph-detection refs and transition-switching logic that caused a visible height jump when the transition changed from spring to instant mid-animation. The spring (stiffness 300, damping 30) naturally handles both cases: large initial morph (0→200px) takes ~300ms for a visible effect, while streaming increments (~10-20px) settle in <50ms. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Framer Motion's height:'auto' measures once at mount and snaps when the spring finishes, causing a 50-100px jump when streaming tokens grow content during the animation. Replace with useLayoutEffect that temporarily flips to height:auto, measures natural height via getBoundingClientRect, restores the spring value (all before paint), and feeds the measurement to a useSpring. Capped at 600px so the flex chain stays intact and the scroll container can scroll when full. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Two fixes for auto-scroll breaking when the conversation reaches max height: 1. Height cap: measure actual flex-available space (parent clientHeight minus sibling heights) instead of a hardcoded 600px cap. The spring now targets the exact rendered height, so the scroll container's internal layout matches the visible area — no more content hidden behind the input bar. 2. Auto-scroll: check scroll position fresh on each content change instead of relying on isUserNearBottomRef, which goes stale when spring animation triggers layout-induced scroll events. Treat "no overflow" as "at the bottom" so the growth-to-scroll transition is seamless. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The isUserNearBottomRef and handleScroll callback became dead code when the auto-scroll effect was rewritten to check scroll position fresh from the DOM. Remove the unused ref, callback, onScroll binding, and the test that only exercised the dead path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Mock stubs must match framer-motion's `use`-prefixed export names; setTargetHeight in useLayoutEffect is intentional (measure before paint). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 5, 2026
quiet-node
added a commit
that referenced
this pull request
Apr 10, 2026
* feat: add Apple Sheet spring morph transition for askbar-to-chat mode Replace the abrupt class-swap transition with a cohesive spring-physics morph: the container bounces open via Framer Motion layout animation, chat content slides down from above, and the input bar glides into position — all driven by a pronounced spring (stiffness 300, damping 20). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use height animation for morph to prevent clipping and overlap Replace Framer Motion layout transforms with explicit height animation (0 → auto) on ConversationView. Layout transforms used CSS scale which overflowed the native window boundary, causing bottom clipping during the spring overshoot. Height animation grows the chat area via real CSS height changes — no transforms, no clipping, no input bar overlap. The isMorphing ref is set synchronously during render so the spring transition is active on the exact frame where chat mode activates. After 600ms the ref flips to false, switching streaming resizes to instant (duration: 0) to prevent the input bar from lagging behind growing content. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use always-on spring for morph height animation Remove morph-detection refs and transition-switching logic that caused a visible height jump when the transition changed from spring to instant mid-animation. The spring (stiffness 300, damping 30) naturally handles both cases: large initial morph (0→200px) takes ~300ms for a visible effect, while streaming increments (~10-20px) settle in <50ms. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: replace height auto snap with spring-driven content tracking Framer Motion's height:'auto' measures once at mount and snaps when the spring finishes, causing a 50-100px jump when streaming tokens grow content during the animation. Replace with useLayoutEffect that temporarily flips to height:auto, measures natural height via getBoundingClientRect, restores the spring value (all before paint), and feeds the measurement to a useSpring. Capped at 600px so the flex chain stays intact and the scroll container can scroll when full. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: reliable auto-scroll during spring-driven height animation Two fixes for auto-scroll breaking when the conversation reaches max height: 1. Height cap: measure actual flex-available space (parent clientHeight minus sibling heights) instead of a hardcoded 600px cap. The spring now targets the exact rendered height, so the scroll container's internal layout matches the visible area — no more content hidden behind the input bar. 2. Auto-scroll: check scroll position fresh on each content change instead of relying on isUserNearBottomRef, which goes stale when spring animation triggers layout-induced scroll events. Treat "no overflow" as "at the bottom" so the growth-to-scroll transition is seamless. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove dead scroll-pinning ref and handler The isUserNearBottomRef and handleScroll callback became dead code when the auto-scroll effect was rewritten to check scroll position fresh from the DOM. Remove the unused ref, callback, onScroll binding, and the test that only exercised the dead path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * formated code * chore: suppress intentional eslint warnings with inline directives Mock stubs must match framer-motion's `use`-prefixed export names; setTargetHeight in useLayoutEffect is intentional (measure before paint). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ---------
quiet-node
added a commit
that referenced
this pull request
Apr 10, 2026
* feat: add Apple Sheet spring morph transition for askbar-to-chat mode Replace the abrupt class-swap transition with a cohesive spring-physics morph: the container bounces open via Framer Motion layout animation, chat content slides down from above, and the input bar glides into position — all driven by a pronounced spring (stiffness 300, damping 20). * fix: use height animation for morph to prevent clipping and overlap Replace Framer Motion layout transforms with explicit height animation (0 → auto) on ConversationView. Layout transforms used CSS scale which overflowed the native window boundary, causing bottom clipping during the spring overshoot. Height animation grows the chat area via real CSS height changes — no transforms, no clipping, no input bar overlap. The isMorphing ref is set synchronously during render so the spring transition is active on the exact frame where chat mode activates. After 600ms the ref flips to false, switching streaming resizes to instant (duration: 0) to prevent the input bar from lagging behind growing content. * fix: use always-on spring for morph height animation Remove morph-detection refs and transition-switching logic that caused a visible height jump when the transition changed from spring to instant mid-animation. The spring (stiffness 300, damping 30) naturally handles both cases: large initial morph (0→200px) takes ~300ms for a visible effect, while streaming increments (~10-20px) settle in <50ms. * fix: replace height auto snap with spring-driven content tracking Framer Motion's height:'auto' measures once at mount and snaps when the spring finishes, causing a 50-100px jump when streaming tokens grow content during the animation. Replace with useLayoutEffect that temporarily flips to height:auto, measures natural height via getBoundingClientRect, restores the spring value (all before paint), and feeds the measurement to a useSpring. Capped at 600px so the flex chain stays intact and the scroll container can scroll when full. * fix: reliable auto-scroll during spring-driven height animation Two fixes for auto-scroll breaking when the conversation reaches max height: 1. Height cap: measure actual flex-available space (parent clientHeight minus sibling heights) instead of a hardcoded 600px cap. The spring now targets the exact rendered height, so the scroll container's internal layout matches the visible area — no more content hidden behind the input bar. 2. Auto-scroll: check scroll position fresh on each content change instead of relying on isUserNearBottomRef, which goes stale when spring animation triggers layout-induced scroll events. Treat "no overflow" as "at the bottom" so the growth-to-scroll transition is seamless. * refactor: remove dead scroll-pinning ref and handler The isUserNearBottomRef and handleScroll callback became dead code when the auto-scroll effect was rewritten to check scroll position fresh from the DOM. Remove the unused ref, callback, onScroll binding, and the test that only exercised the dead path. * formated code * chore: suppress intentional eslint warnings with inline directives Mock stubs must match framer-motion's `use`-prefixed export names; setTargetHeight in useLayoutEffect is intentional (measure before paint). ---------
quiet-node
added a commit
that referenced
this pull request
Apr 11, 2026
* feat: add Apple Sheet spring morph transition for askbar-to-chat mode Replace the abrupt class-swap transition with a cohesive spring-physics morph: the container bounces open via Framer Motion layout animation, chat content slides down from above, and the input bar glides into position — all driven by a pronounced spring (stiffness 300, damping 20). * fix: use height animation for morph to prevent clipping and overlap Replace Framer Motion layout transforms with explicit height animation (0 → auto) on ConversationView. Layout transforms used CSS scale which overflowed the native window boundary, causing bottom clipping during the spring overshoot. Height animation grows the chat area via real CSS height changes — no transforms, no clipping, no input bar overlap. The isMorphing ref is set synchronously during render so the spring transition is active on the exact frame where chat mode activates. After 600ms the ref flips to false, switching streaming resizes to instant (duration: 0) to prevent the input bar from lagging behind growing content. * fix: use always-on spring for morph height animation Remove morph-detection refs and transition-switching logic that caused a visible height jump when the transition changed from spring to instant mid-animation. The spring (stiffness 300, damping 30) naturally handles both cases: large initial morph (0→200px) takes ~300ms for a visible effect, while streaming increments (~10-20px) settle in <50ms. * fix: replace height auto snap with spring-driven content tracking Framer Motion's height:'auto' measures once at mount and snaps when the spring finishes, causing a 50-100px jump when streaming tokens grow content during the animation. Replace with useLayoutEffect that temporarily flips to height:auto, measures natural height via getBoundingClientRect, restores the spring value (all before paint), and feeds the measurement to a useSpring. Capped at 600px so the flex chain stays intact and the scroll container can scroll when full. * fix: reliable auto-scroll during spring-driven height animation Two fixes for auto-scroll breaking when the conversation reaches max height: 1. Height cap: measure actual flex-available space (parent clientHeight minus sibling heights) instead of a hardcoded 600px cap. The spring now targets the exact rendered height, so the scroll container's internal layout matches the visible area — no more content hidden behind the input bar. 2. Auto-scroll: check scroll position fresh on each content change instead of relying on isUserNearBottomRef, which goes stale when spring animation triggers layout-induced scroll events. Treat "no overflow" as "at the bottom" so the growth-to-scroll transition is seamless. * refactor: remove dead scroll-pinning ref and handler The isUserNearBottomRef and handleScroll callback became dead code when the auto-scroll effect was rewritten to check scroll position fresh from the DOM. Remove the unused ref, callback, onScroll binding, and the test that only exercised the dead path. * formated code * chore: suppress intentional eslint warnings with inline directives Mock stubs must match framer-motion's `use`-prefixed export names; setTargetHeight in useLayoutEffect is intentional (measure before paint). ---------
This was referenced Apr 11, 2026
nadalpiantini
added a commit
to Openclaw-claws/thuki
that referenced
this pull request
Jul 27, 2026
Full audit cleanup after agency-agents tri-review (Reality Checker, API Tester, Performance Benchmarker) flagged real issues hidden by self-graded scoring. Tests repaired (was 145 failing pre-existing rebrand drift): - IntroStep.test.tsx: Spanish onboarding strings (Antes de empezar, Doble-tap, Empezar, etc) - AskBarView.test.tsx: placeholder Pregúntale a Sephirot... + img alt Sephirot - OnboardingView.test.tsx: Activar Accesibilidad, Abrir ajustes de grabación de pantalla, Cerrar y reabrir Sephirot, Activo badge - index.test.tsx: stages text - App.test.tsx: combined cascading replacements Cord client improvements (agentTarsClient.ts): - stripCodeFences() removes wrapping ```python/```json fences from DeepSeek responses so the bubble shows clean content (case quiet-node#6, quiet-node#15 from stress test were leaking raw markdown) - Added 5 unit tests for stripCodeFences (single fence, mid-content preservation, no-fence passthrough) Type pollution cleanup (useOllama.ts + App.tsx): - New `transportError` field on Message for non-Ollama failures ('agent-tars-down' | 'agent-tars-timeout' | 'agent-tars-bad-response' | 'agent-tars-unknown') replaces the misleading errorKind: 'Other' reuse of OllamaErrorKind - Error messages translated to Spanish (Alan is hispanoparlante; was English in earlier ship) Integration tests (browseFlow.integration.test.tsx — NEW): - 7 cases covering: happy path with fence stripping, proxy 504 → TIMEOUT, network unreachable → DOWN, stale 404 → recreate, UTF-8 multi-script preservation, empty content → BAD_RESPONSE, 3-concurrent → 1 createSession (mutex) Real-workload validation (20-case DeepSeek stress, post-patches): - 20/20 OK, 0 errors (was 18/20 before patches) - Latency: p50=2245ms, p95=11325ms, max=11497ms - The 2 cases that previously timed out at 75s (quiet-node#5 rd.bank, quiet-node#11 long.task) now complete in 8.0s and 11.5s respectively, confirming agent-tars internal stalls are recoverable on retry Suite total: 30 files, 627/627 tests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
height: 'auto'snap with a spring-driven height animation (useMotionValue+useSpring) that smoothly tracks growing content during streamingisUserNearBottomRef) andhandleScrollcallback that became unused after the auto-scroll rewriteTest plan
🤖 Generated with Claude Code