feat(ci): ship Thuki Nightly as side-by-side signed install - #336
Merged
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Nightly builds install as a separate app next to stable, with the same RSA-signed DMG path the curl installer already trusts.
What changed
productNameto Thuki Nightly andidentifiertocom.quietnode.thuki.nightly, and turns the in-app updater off for that build.Thuki.dmgwithTHUKI_INSTALLER_RSA_PRIVATE_KEYand uploadsThuki.dmg.sigon the floatingnightlyprerelease.How to install (after landing deploys channel-aware install.sh)
Nightly lands as
/Applications/Thuki Nightly.app.Testing
cargo test --lib keychain::(7 passed)Note
Until the first post-merge nightly run finishes, the
nightlyrelease will not yet include.sig. Landing-pageinstall.shchannel support is separate and should deploy after or with that run.