fix(prompt): stop base system prompt forcing language guesses on all providers - #350
Merged
Merged
Conversation
…providers Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #349. Since v0.16.0 the base system prompt carried an always-on instruction to reply in the language of the user's latest message, with Vietnamese and Japanese named as examples. It rode in on the search language-parity work (#326) but reaches every provider on every chat turn, and on small local models the named-language tokens can steer replies into Vietnamese even for English questions. This PR removes that instruction from the base prompt.
Key changes
src-tauri/prompts/system_prompt.txt, the exact inverse of the hunk feat: search language parity across retrieval and answers #326 added there.Testing
bun run test:all:coverage: frontend and backend green, 100% coverage gate holds.bun run validate-build: clean.Note: existing installs pick up the corrected default automatically; the config loader replaces a non-customized
prompt.systemwith the current built-in prompt on load.