Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time-Aware Base Fee Calculation #4

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Conversation

adietrichs
Copy link

@adietrichs adietrichs commented Oct 28, 2021

wip

todo:

  • adapt specification
  • ensure all low-number edge cases are covered
  • add MAX_GAS_TARGET_PERCENT to rationale
  • write out motivation, rationale, backward compatibility, security considerations (so far: keywords)
  • write abstract

MAX_GAS_TARGET_PERCENT = 95

class World(ABC):
def validate_block(self, block: Block) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to be explicit about what exactly has been changed comparing to the original formula. Also, it would probably be clearer to have a function compute_parent_adjusted_gas_target and replace parent_gas_target in the original formula with parent_adjusted_gas_target = compute_parent_adjusted_gas_target(...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants