Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server side diff #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Use server side diff #48

wants to merge 6 commits into from

Conversation

aaron-weisberg-qz
Copy link
Contributor

@aaron-weisberg-qz aaron-weisberg-qz commented Jul 19, 2024 •
edited
Loading

  • Local diffing is deprecated in-favor or server-side diffs
  • This also has the benefits of cleaning up the diff output to actually only show apps that have real diffs

mattmelgard-qz
mattmelgard-qz approved these changes Jul 19, 2024
View reviewed changes
Copy link

@mattmelgard-qz mattmelgard-qz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, only thing I'm wondering is whether we might want to expose this as an option on the action itself so that we can more easily switch from one to the other if needed

@fcrespofastly
Copy link

This would be very useful @aaron-weisberg-qz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmelgard-qz mattmelgard-qz mattmelgard-qz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaron-weisberg-qz @fcrespofastly @mattmelgard-qz