-
Notifications
You must be signed in to change notification settings - Fork 781
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Core: Fix event "runtime" data to be rounded to milliseconds
Follows-up b70af72, which corrected this in the UI, but this means any plugins and integrations reporting `details.runtime` are still affected by the needless precision. This affects: * `QUnit.log`, `QUnit.testDone`, `QUnit.moduleDone` and `QUnit.done`. * `on('testEnd')`, `on('suiteEnd')`, and `on('runEnd')`. I was initially cautious about this as I worried that perhaps consumers would accumulate these and then become increasingly less accurate in large test suites where perhaps most leaf nodes round to 0ms. However I have no such case in practice. Generally, for total times the reported totals can be, should be, and are being used. Ref #1678.
- Loading branch information
Showing
5 changed files
with
10 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters