Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add QUnit.hooks to globally add beforeEach and afterEach #1670

Closed
wants to merge 3 commits into from

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Feb 12, 2022

Ref #1475.

Avoid a circular dependency as detected by rollup

Before
```
src/core.js -> src/module.js -> src/core.js
src/core.js -> src/assert.js -> src/test.js -> src/core.js
src/assert.js -> src/test.js -> src/assert.js
src/test.js -> src/core/processing-queue.js -> src/test.js
...and 2 more
```

After
```
src/core.js -> src/assert.js -> src/test.js -> src/core.js
src/assert.js -> src/test.js -> src/assert.js
src/test.js -> src/core/processing-queue.js -> src/test.js
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant