Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remodel desktop notifications #626

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rpallai
Copy link
Contributor

@rpallai rpallai commented Aug 15, 2019

This is a request for comments to improve desktop notifications.

First of all, I'm not a big fan of the client mode but showing the content of received messages in the popup is a must and I wasn't able to find a better solution. The old default behaviour is available with the popup_mode=server and popup_tweaks=highlight+,intrusive settings.

Todo:

  • discuss the approach
  • test on Windows and OSX (help needed)
  • remove useless debug code

Major improvements of this patch:
- Content of new messages can appear in the popup;
- Users may be notified about other events than highlight;
- Presence of unseen events is permanently visible on the tray icon;
- Tray icon can be used to walk through rooms with unseen event
@rpallai rpallai added enhancement A feature or change request for Quaternion help wanted More information/contribution needed labels Aug 15, 2019
@KitsuneRal
Copy link
Member

For better or worse, the client-side triggering of notifications is the way to go, simply because it's the only working way with E2EE. I also agree that showing the content preview is a wanted feature. In order to avoid code duplication in events rendering, though, I'd like to move the event visualisation code to the library (this will also help to remove code duplication between Spectral and Quaternion). I wanted to do it for quite a bit of time already but never got even close to starting. If you feel brave enough to get into this rabbit hole, let's discuss how to do it in the library in an extensible way.

@rpallai
Copy link
Contributor Author

rpallai commented Aug 16, 2019

For better or worse, the client-side triggering of notifications is the way to go, simply because it's the only working way with E2EE.

Good point, I didn't take E2EE into consideration. Client-side triggering is here to stay.

In order to avoid code duplication in events rendering, though, I'd like to move the event visualisation code to the library

I take your point but I'm mainly motivated in practical usability improvements rather than code refactoring so I'm afraid this is still waiting for you. Would you merge this PR with this small volume of code duplication?

Does it work on Windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for Quaternion help wanted More information/contribution needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants