Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing a certain page from bookmarks #2335

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Aug 2, 2023

In some cases, when we swap out pages, we might get rid of extra pages
that are no longer there. This allows removing bookmarks for such pages.
This is really meant for pages like 612 (the du3a page) in Naskh, in
preparation for replacing this set with the King Fahd images, which do
not have this page.

In some cases, when we swap out pages, we might get rid of extra pages
that are no longer there. This allows removing bookmarks for such pages.
This is really meant for pages like 612 (the du3a page) in Naskh, in
preparation for replacing this set with the King Fahd images, which do
not have this page.
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  12.2 MiB │  12.2 MiB │ +1.4 KiB │  31.1 MiB │  31.1 MiB │ +4.2 KiB 
     arsc │   2.1 MiB │   2.1 MiB │      0 B │   2.1 MiB │   2.1 MiB │      0 B 
 manifest │   5.5 KiB │   5.5 KiB │      0 B │  26.5 KiB │  26.5 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │      0 B │   1.8 MiB │   1.8 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 180.5 KiB │ 180.5 KiB │     -2 B │ 369.7 KiB │ 369.7 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  16.5 MiB │  16.5 MiB │ +1.4 KiB │  36.1 MiB │  36.1 MiB │ +4.2 KiB 


@ahmedre ahmedre merged commit cdfc3c6 into master Aug 3, 2023
4 checks passed
@ahmedre ahmedre deleted the allow_removing_marked_pages branch August 3, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant