Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Auto Support 🚗 #2648

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jibraniqbal666
Copy link

Salam Y'all

Alhamdullilah, I was finally able to add the android auto support but with limitations, and the code is pretty basic for now.

Video (With sound):

Auto_Quran-1.mov

Feature:

  • Surah List
  • Media Play

Limitation:

  • Only one Sheikh.
  • No Pause or Seek Support.

Most of the code is in separate module and I am planning to add more features later, inshaAllah

Run with autoquran configuration to try it with Automotive emulator.

Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  20.3 MiB │  20.3 MiB │   -265 B │  65.5 MiB │  65.5 MiB │ -1.1 KiB 
     arsc │   2.2 MiB │   2.2 MiB │   -860 B │   2.2 MiB │   2.2 MiB │   -860 B 
 manifest │   5.6 KiB │   5.6 KiB │      0 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │    -38 B │   1.8 MiB │   1.8 MiB │   -248 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 188.6 KiB │ 188.6 KiB │    +24 B │ 385.6 KiB │ 385.6 KiB │     -2 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  24.7 MiB │  24.7 MiB │ -1.1 KiB │  70.6 MiB │  70.6 MiB │ -2.2 KiB 


Copy link

Upgraded Dependencies
app.cash.molecule:molecule-runtime:1.4.1, (changed from 1.4.2)
app.cash.molecule:molecule-runtime-android:1.4.1, (changed from 1.4.2)
com.google.dagger:dagger:2.51, (changed from 2.51.1)
com.squareup.retrofit2:converter-moshi:2.10.0, (changed from 2.11.0)
com.squareup.retrofit2:retrofit:2.10.0, (changed from 2.11.0)
org.jetbrains.compose.runtime:runtime:1.6.0, (changed from 1.6.1)

@ahmedre
Copy link
Contributor

ahmedre commented Mar 30, 2024

wa3laikum alsalam,
masha'Allah Jibran this looks really promising! Looking forward to following your progress here. I am guessing at some point we should probably make our existing AudioService conform to some of these interfaces (MediaBrowserServiceCompat) so they work with Android Auto out of the box.

@jibraniqbal666
Copy link
Author

@ahmedre, should we merge this or i should continue working on this branch?

@ahmedre
Copy link
Contributor

ahmedre commented Mar 30, 2024

let's keep working on it until it's in a more ready state?

@jibraniqbal666
Copy link
Author

Added Next Previous & Seek

@jibraniqbal666
Copy link
Author

[Update]

Quran.media.complete.mp4

Salam, @ahmedre, I have added basic media player functionality, Just required clean up.
Do you think we should merge it after that.

Here is the state below.
Feature:
Surah List ✅
Media Play ✅
Pause ✅
Next ✅
Previous ✅
Seek ✅

Limitation:
Only one Sheikh ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants