This repository was archived by the owner on Mar 20, 2025. It is now read-only.
Fix client not able to connect to ssl host #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasnox
force-pushed
the
fix/qt6-ssl
branch
2 times, most recently
from
1eb2b00 to
f59bce8
Compare
Constructing a `QSslConfiguration()` result in a null/empty configuration. The fact that it worked with Qt 5 is pure luck, ie Qt bug. The bug eventually get fixed in Qt 6 but not backported which lead to this needed fix. We need to init from the default configuration else we have no certificates filled.
lnjX
approved these changes
Jan 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructing a
QSslConfiguration()result in a null/empty configuration. The fact that it worked with Qt 5 is pure luck, ie Qt bug. The bug eventually get fixed in Qt 6 but not backported which lead to this needed fix. We need to init from the default configuration else we have no certificates filled.PR check list:
\since QXmpp 1.X,QXMPP_EXPORTdoc/doap.xmlclang-format -i src/<edited-file(s)> tests/<edited-file(s)>