Merge pull request #3 from IoannaNika/revert-1-add_clock_functions

correct difftime to match base r behavior
r-dbi · Dec 10, 2024 · df43f0f · df43f0f
2 parents e633470 + 08c74bf
commit df43f0f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/dplyr.R b/R/dplyr.R
@@ -366,7 +366,7 @@ sql_translation.BigQueryConnection <- function(x) {
         dbplyr:::check_unsupported_arg(tz)
         dbplyr:::check_unsupported_arg(units, allowed = "DAY")
 
-        dbplyr::build_sql("DATE_DIFF(CAST(", time2, " AS DATE), CAST(", time1, " AS DATE), DAY)")
+        dbplyr::build_sql("DATE_DIFF(CAST(", time1, " AS DATE), CAST(", time2, " AS DATE), DAY)")
       },
     ),
     dbplyr::sql_translator(.parent = dbplyr::base_agg,

diff --git a/tests/testthat/test-dplyr.R b/tests/testthat/test-dplyr.R
@@ -291,5 +291,5 @@ test_that("difftime clock function translates to correct sql", {
     ) %>%
     dbplyr::sql_build(simulate_bigrquery())
 
-  expect_equal(sql$select[[2]], "DATE_DIFF(CAST(`time2` AS DATE), CAST(`time1` AS DATE), DAY)")
+  expect_equal(sql$select[[2]], "DATE_DIFF(CAST(`time1` AS DATE), CAST(`time2` AS DATE), DAY)")
 })