-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for SAS length #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add SASlengrh
examples to the two man pages and see the other comments.
@warnes Thanks for the quick review. Updates have been made. |
@warnes Any other changes you'd like to see on this? |
Code looks good! Just a couple of minor nits. I'm going to pull down the code and run some checks now. -G |
* Don't assign empty ("" or " ") labels to datasets * Use auto-detected SAS attributes unless user has specified them. * `testDates.R` now does an explicit compare to detect regressions like r-gregmisc#22.
@warnes Any chance this could be merged soon? The length update here would allow CDISC compliant XPT file generation, which is going to be a huge benefit to the pharma industry's use of R. |
@warnes Do you have a time frame for this being pushed up to CRAN? |
Good to see these updates; My team just duplicated this before seeing you fixed it. |
@warnes do you intend to move this version to CRAN anytime soon? It would be immensely valuable to have this PR incorporated and available to install via CRAN. |
This closes #20.
I've added a
SASlength
function to set and return theSASlength
attribute similar to the other attribute setters. I've updated the documentation, NAMESPACE, and NEWS.md files as well.Let me know if there are any changes you want to see before sending to CRAN. R CMD CHECK is all green.