Features/42 read asc perkin elmer #47
Conversation
R/read_asc_PerkinElmer.R
Outdated
| for(flu in flu_file){ | ||
| expect_message(spc <- read_asc_PerkinElmer(flu)) | ||
|
|
||
| expect_equal(length(spc@wavelength), 181) |
There was a problem hiding this comment.
Checking the length only is fine with me - but if we check the colnames of $spc, it is inconsistent not to check the actual wavelengths.
There was a problem hiding this comment.
The values of the lowest, the highest, and a few internediate wavelengths should be checked in addition to the length of this vector.
There was a problem hiding this comment.
The change looks fine, but the checks fail due to a missing function? Is that function in the develop branch already, so if we merge, it will be fine? If so, consider this approved and merge it at your convenience. Otherwise please figure out where that renamed function is, I've seen it discussed today but don't recall where.
There was a problem hiding this comment.
@sangttruong, add unit tests defined in template #55 as additional tests to the current ones.
Add unit test for read_asc_PerkinElmer.R
Resolve #42