Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #118 #119

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix #118 #119

merged 1 commit into from
Oct 9, 2023

Conversation

AlreadyTakenJonas
Copy link
Contributor

read.spc no longer fails and does its thing like the good ol times.

@AlreadyTakenJonas
fix r-hyperspec#118
7e2f4f9 
read.spc no longer fails and does its thing like the good ol times
@GegznaV
Copy link
Member

GegznaV commented Sep 5, 2023

See discussion in:

@GegznaV GegznaV mentioned this pull request Sep 5, 2023
Closed
@GegznaV
Copy link
Member

GegznaV commented Oct 9, 2023

@cbeleites, does this fix seem reasonable? Does it work for you with any additional issues?

@GegznaV
Copy link
Member

GegznaV commented Oct 9, 2023

I found out that this issue is already solved in r-hyperspec/hySpc.read.spc repo:

https://github.com/r-hyperspec/hySpc.read.spc/blob/7d4295bce8500205211017f10365941531870469/R/read_spc.R#L558

image

@GegznaV
Copy link
Member

GegznaV commented Oct 9, 2023

So I'm merging this.

@GegznaV GegznaV merged commit 344e992 into r-hyperspec:develop Oct 9, 2023
5 of 7 checks passed
@AlreadyTakenJonas
Copy link
Contributor Author

Thank you very much!

@AlreadyTakenJonas AlreadyTakenJonas deleted the fixIssue118 branch October 9, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Topic: file IO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlreadyTakenJonas @GegznaV