Fixes for local testing issues #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using the default plot device was causing `devtools::test()` to create a bunch of plot files in the test directory. I don't think there's any reason to use the default plot device (since that may lead to windows popping up for the user), so we just switch to using `pdf(NULL)` everywhere * There was one test that used `dev.new()` to start a new device; there I made sure that the new device was always a quiet `pdf()` device. * I also fixed a partial argument match warning that was causing a local test failure for me since I have `options(warnPartialMatchArgs = TRUE)`
(To ensure that (e.g.) we can compute string widths)
hadley
commented
Jun 16, 2024
| } else dev.new() | ||
| # Ensure we have a graphics device available for recording, but choose | ||
| # one that's available on all platforms and doesn't write to disk | ||
| pdf(file = NULL) |
There was a problem hiding this comment.
We could alternatively use something like devoid::void_dev() but that would add a dependency, and there doesn't appear to be any performance advantage:
x <- rnorm(1e5)
y <- rnorm(1e5)
f <- function(dev) {
dev()
plot(x, y)
dev.off()
}
bench::mark(
f(devoid::void_dev),
f(\() pdf(NULL))
)
#> # A tibble: 2 × 3
#> expression min median
#> <bch:expr> <bch:tm> <bch:tm>
#> 1 f(devoid::void_dev) 10.8ms 11.1ms
#> 2 f(function() pdf(NULL)) 10.9ms 11.2ms
cderv
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devtools::test()to create a bunch of plot files in the test directory. I don't think there's any reason to use the default plot device (since that may lead to windows popping up for the user), so we just switch to usingpdf(NULL)everywheredev.new()to start a new device; there I made sure that the new device was always a quietpdf()device.options(warnPartialMatchArgs = TRUE)