Collect output in an accumulating stack #166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this slightly simplifies the existing code, and as you'll seen in upcoming PRs, allows us to tease apart concerns to yield code that's a little easier to understand.
You might be surprised to see me repeatedly growing a list, but this is quite performant in modern versions of R:
(And for older versions of R, I don't think it would the typical length of output is going to cause a performance bottleneck)