Skip to content

Pull out plot hook registration into our function #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 21, 2024

@cderv this is a straightforward refactoring, but it's a good place to ask if you have any questions about this pattern of using defer() in a wrapper function.

@hadley hadley requested a review from cderv June 21, 2024 10:02
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think I got this right already through learning with testthat and withr.

So all good - this is indeed meaningful refactoring once defer mechanism is known.

@hadley hadley merged commit a6a367d into main Jun 21, 2024
13 checks passed
@hadley hadley deleted the local-plot-hooks branch June 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants