Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify context() call implementation #217

Closed
wants to merge 2 commits into from
Closed

Clarify context() call implementation #217

wants to merge 2 commits into from

Conversation

hadley
Copy link
Member

@hadley hadley commented Aug 21, 2024

With fresh eyes, I found this code and explanation a little easier to read.

@hadley hadley requested a review from lionel- August 21, 2024 16:30
lionel-
lionel- reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it does the opposite of clarifying, I can't understand what this does in isolation (is there any promise substitution going on?) whereas the original implementation is immediately clear to me.

Can you use bquote() instead?

@hadley
Copy link
Member Author

hadley commented Aug 21, 2024

Yeah, bquote() looks even better.

@hadley
Copy link
Member Author

hadley commented Aug 21, 2024

But bquote() seems not to work in 3.6 😬

@hadley hadley closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel- lionel- lionel- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @lionel-