Control how spaces are handed in query strings #609

hadley · 2024-12-23T19:29:19Z

Fixes #432

jonthegeek

1 typo (unless I'm missing reasoning behind the second %). This will definitely be useful! I can't remember which api it was for, but I definitely had to implement this in front of req_url_query() before!

jonthegeek · 2024-12-23T20:02:58Z

R/req-url.R

@@ -60,12 +60,17 @@ req_url <- function(req, url) {
 #'   If none of these options work for your needs, you can instead supply a
 #'   function that takes a character vector of argument values and returns a
 #'   a single string.
+#' @param .space How should spaces in query params be escaped? The default,
+#'   "percent", uses standard percent encoding (i.e. `%20%`), but you can opt-in


Suggested change

#' "percent", uses standard percent encoding (i.e. `%20%`), but you can opt-in

#' "percent", uses standard percent encoding (i.e. `%20`), but you can opt-in

Control how spaces are handed in query strings

c182ef4

Fixes #432

jonthegeek reviewed Dec 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Control how spaces are handed in query strings #609

Control how spaces are handed in query strings #609

hadley commented Dec 23, 2024

jonthegeek left a comment

jonthegeek Dec 23, 2024

	#' "percent", uses standard percent encoding (i.e. `%20%`), but you can opt-in
	#' "percent", uses standard percent encoding (i.e. `%20`), but you can opt-in

Control how spaces are handed in query strings #609

Are you sure you want to change the base?

Control how spaces are handed in query strings #609

Conversation

hadley commented Dec 23, 2024

jonthegeek left a comment

Choose a reason for hiding this comment

jonthegeek Dec 23, 2024

Choose a reason for hiding this comment