-
Notifications
You must be signed in to change notification settings - Fork 195
Check if tests are coupled by randomizing order in which tests are run #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
it looks like shuffle=TRUE is designed to make this trivial to test: |
|
Yes :) |
|
The failing tests with testthat 3.3.0 are expected to fail (cf. #2937). The incompatibility needs to be resolved in a separate PR. |
|
@MichaelChirico Took only 3 years but the builds are now passing 😆 |
|
could you run this locally, say, 10 times to guard against flakiness before we do the initial merge? I'm also wondering if this should be run on every commit or just during release wdyt? |
| rmarkdown, | ||
| rstudioapi (>= 0.2), | ||
| testthat (>= 3.2.1), | ||
| testthat (>= 3.3.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't technically need this since it's GHA-only requirement right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't, but it's a good way to enforce the dev team to upgrade to use the latest version, which will become especially relevant if we run into a flaky test.
I know it's not ideal because they are forced to make this update globally, since we aren't using project dependency manager (like {renv}).
SGTM. Do we have a standardized release process? E.g. a branch name that always starts with |
closes #1937