Skip to content

Conversation

@IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Mar 26, 2023

closes #1937

@codecov-commenter

This comment was marked as off-topic.

@IndrajeetPatil

This comment was marked as outdated.

@MichaelChirico

This comment was marked as outdated.

@MichaelChirico

This comment was marked as outdated.

@MichaelChirico

This comment was marked as outdated.

@IndrajeetPatil

This comment was marked as outdated.

@AshesITR

This comment was marked as outdated.

@IndrajeetPatil IndrajeetPatil added the internals Issues related to inner workings of lintr, i.e., not user-visible label Jun 7, 2024
@MichaelChirico
Copy link
Collaborator

it looks like shuffle=TRUE is designed to make this trivial to test:

https://tidyverse.org/blog/2025/11/testthat-3-3-0/

@IndrajeetPatil
Copy link
Collaborator Author

Yes :)

r-lib/testthat#1942

@IndrajeetPatil
Copy link
Collaborator Author

The failing tests with testthat 3.3.0 are expected to fail (cf. #2937). The incompatibility needs to be resolved in a separate PR.

@IndrajeetPatil
Copy link
Collaborator Author

@MichaelChirico Took only 3 years but the builds are now passing 😆

@IndrajeetPatil IndrajeetPatil changed the title Check if tests are coupled Check if tests are coupled by randomizing order in which tests are run Nov 16, 2025
@MichaelChirico
Copy link
Collaborator

could you run this locally, say, 10 times to guard against flakiness before we do the initial merge?

I'm also wondering if this should be run on every commit or just during release wdyt?

rmarkdown,
rstudioapi (>= 0.2),
testthat (>= 3.2.1),
testthat (>= 3.3.0),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't technically need this since it's GHA-only requirement right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't, but it's a good way to enforce the dev team to upgrade to use the latest version, which will become especially relevant if we run into a flaky test.

I know it's not ideal because they are forced to make this update globally, since we aren't using project dependency manager (like {renv}).

@IndrajeetPatil
Copy link
Collaborator Author

I'm also wondering if this should be run on every commit or just during release wdyt?

SGTM. Do we have a standardized release process? E.g. a branch name that always starts with rc-*?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internals Issues related to inner workings of lintr, i.e., not user-visible testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check if unit tests are coupled

5 participants