Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address caching issues #2715

Closed
wants to merge 4 commits into from
Closed

Address caching issues #2715

wants to merge 4 commits into from

Conversation

jayhesselberth
Copy link
Collaborator

@jayhesselberth jayhesselberth commented Jul 13, 2024

  • New user_dir_cache() to find cache directory on user machine, because tools::R_user_dir() is available in R > 4.0.0 and pkgdown depends on >3.6. Approach modified from wch/r-source/src/library/tools/R/userdir.R

  • Added cache cleaning to clean_site()

  • Fixes tools::R_user_dir breaks usage with older R versions #2714

- New `user_dir_cache()` to find cache directory on user machine, because `tools::R_user_dir()` is available in R > 4.0.0 and pkgdown depends on >3.6. Approach modified from wch/r-source/src/library/tools/R/userdir.R

- Added cache cleaning to `clean_site()`
Copy link

github-actions bot commented Jul 13, 2024

@jayhesselberth jayhesselberth requested a review from hadley July 13, 2024 13:20
@jayhesselberth
Copy link
Collaborator Author

Should we just set up cache_dir in as_pkgdown() so that it is available as pkg$cache_dir throughout?

@hadley
Copy link
Member

hadley commented Jul 13, 2024

I think we can just bump the pkgdown R version requirement to R 4.0.0 in line with the tidyverse version policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools::R_user_dir breaks usage with older R versions
2 participants