Remove depency on env_unlock()
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid `env_unlock()`
lionel-
force-pushed
the
feature/env-unlock
branch
from
b9c2e59 to
ab70cc6
Compare
|
rlang side at r-lib/rlang#1720 |
hadley
approved these changes
Jun 27, 2024
| rlang::env_unlock(ns) | ||
|
|
||
| if (!env_has(ns, "::")) { | ||
| return() |
There was a problem hiding this comment.
It feels like it would be useful to log this in some way, but if you think it only affects rlang, it's probably fine as is.
There was a problem hiding this comment.
It's only used in rlang AFAIK and even there I think we ran into other issues that prevented us from using :: in some standalone files. So I prefer to keep this feature low-key, and a warning would affect all pkgload users. But you're right that if this feature does end up being needed by someone, they will have a very hard time to discover this fix. We can revisit if someone reports an issue about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276.
Progress towards r-lib/rlang#1705.
The
resetargument ofload_all()is now deprecated. Its purpose was to reuse the namespace instead of creating one from scratch. But this code path is not the default, not well tested, and required unlocking the namespace which is no longer possible on recent versions of R.We no longer hot-patch
::in detached namespaces by default. The patched version redirected self-calls via::to the detached namespace rather than the currently loaded namespace. This is only needed in very special cases, such as packages containing both native code and standalone files. If the patched::is needed, just assign it on load:This is not documented because AFAIK only rlang needed this behaviour.