Check for sealed namespace in is_installed()

Closes #1378
r-lib · May 24, 2022 · 5fcde82 · 5fcde82
1 parent 2b472ff
commit 5fcde82
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # rlang (development version)
 
+* `is_installed()` now detects unsealed namespaces (#1378). This fixes
+  inconsistent behaviour when run within user onLoad hooks.
+
 * Source references in backtraces and `last_error()`/`last_trace()` instructions
   are now clickable in IDEs that support links (#1396).
 

diff --git a/R/session.R b/R/session.R
@@ -74,7 +74,13 @@ detect_installed <- function(info) {
   }
 
   flatten_lgl(pmap(info, function(pkg, cmp, ver) {
-    if (requireNamespace(pkg, quietly = TRUE)) {
+    # Check for sealed namespaces to protect against `is_installed()`
+    # being called from user hooks of `pkg` (#1378)
+    is_fully_loaded <-
+      requireNamespace(pkg, quietly = TRUE) &&
+      env_is_locked(ns_env(pkg))
+
+    if (is_fully_loaded) {
       is_na(ver) || exec(cmp, utils::packageVersion(pkg), ver)
     } else {
       FALSE