suppress warnings in multcomp::glht summary

r-spatial · Nov 24, 2023 · 179c54c · 179c54c
1 parent 1eee77d
commit 179c54c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: spatialreg
-Version: 1.3-1
-Date: 2023-11-22
+Version: 1.3-2
+Date: 2023-11-24
 Title: Spatial Regression Analysis
 Encoding: UTF-8
 Authors@R: c(person("Roger", "Bivand", role = c("cre", "aut"), email = "[email protected]", comment=c(ORCID="0000-0003-2392-6140")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,8 @@
-# Version 1.3-1 (development)
+# Version 1.3-2 (development)
+
+* suppress warning from `multcomp::glht` as the test which throws the warning is discarded
+
+# Version 1.3-1 (2023-11-23)
 
 * move `expm` from Imports to Suggests #42
 

diff --git a/R/ML_models.R b/R/ML_models.R
@@ -300,7 +300,7 @@ errorsarlm <- function(formula, data = list(), listw, na.action, weights=NULL,
                     indirImps <- sum_lm_target$coefficients[(m2+1):m, 1:2, drop=FALSE]
                     rownames(indirImps) <- rownames(cm)
                 }
-            lc <- summary(multcomp::glht(lm.target, linfct=cm))
+            suppressWarnings(lc <- summary(multcomp::glht(lm.target, linfct=cm)))
             totImps <- cbind("Estimate"=lc$test$coefficients, "Std. Error"=lc$test$sigma)
           } else if (is.formula(Durbin)) {
 #FIXME
@@ -337,7 +337,7 @@ errorsarlm <- function(formula, data = list(), listw, na.action, weights=NULL,
                 }
               }
               rownames(indirImps) <- xn
-              lc <- summary(multcomp::glht(lm.target, linfct=cm))
+              suppressWarnings(lc <- summary(multcomp::glht(lm.target, linfct=cm)))
               totImps <- cbind("Estimate"=lc$test$coefficients, "Std. Error"=lc$test$sigma)
               if (!is.null(zero_fill)) {
                 if (length(zero_fill) > 0L) {

diff --git a/R/SLX_WX.R b/R/SLX_WX.R
@@ -137,7 +137,7 @@ lmSLX <- function(formula, data = list(), listw, na.action, weights=NULL, Durbin
                 indirImps <- sum_lm_model$coefficients[(m2+1):m, 1:2, drop=FALSE]
                 rownames(indirImps) <- rownames(cm)
             }
-            lc <- summary(multcomp::glht(lm.model, linfct=cm))
+            suppressWarnings(lc <- summary(multcomp::glht(lm.model, linfct=cm)))
             totImps <- cbind("Estimate"=lc$test$coefficients, "Std. Error"=lc$test$sigma)
       } else if (is.formula(Durbin)) {
 #FIXME
@@ -174,7 +174,7 @@ lmSLX <- function(formula, data = list(), listw, na.action, weights=NULL, Durbin
                  }
                }
                rownames(indirImps) <- xn
-               lc <- summary(multcomp::glht(lm.model, linfct=cm))
+               suppressWarnings(lc <- summary(multcomp::glht(lm.model, linfct=cm)))
                totImps <- cbind("Estimate"=lc$test$coefficients,
                      "Std. Error"=lc$test$sigma)
                  if (!is.null(zero_fill)) {