chore: update to latest discordjs and node. #957
Conversation
also changed from ts-node to tsx
| 'GuildMembers', | ||
| 'GuildBans', | ||
| 'GuildEmojisAndStickers', | ||
| 'MessageContent', |
There was a problem hiding this comment.
Note: This is new and will probably require @ljosberinn to update bot permissions on his end
There was a problem hiding this comment.
happy to do that but uh where 👀 is this server settings side on discord or bots permissions on the page somewhere?
There was a problem hiding this comment.
It's on the discord developer portal, under app intents or something.
There was a problem hiding this comment.
this is already active 🎉
| const perms = new Permissions(Permissions.DEFAULT); | ||
| perms.remove(Permissions.FLAGS.VIEW_CHANNEL); | ||
| function addNewRolePermissions(guild: Guild, role: Role) { | ||
| const permissionFlags = PermissionsBitField.Default & ~PermissionsBitField.Flags.ViewChannel |
There was a problem hiding this comment.
question: What's with the ~PermissionsBitField.Flags.ViewChannel particually the ~
There was a problem hiding this comment.
Discord permissions work with a Bit Fields (which are bigints that store permissions encoded as individual bits) and discord.js exposes this now, so doing boolean maths here.
I want to use the default permissions but remove the ability to view the channel.
~ is a bitwise NOT, it flips every bit.
& is a bitwise AND, it ANDs every bit between two numbers
Lets say the default permissions are 0b0111and the view channel permission is 0b0010:
- I
NOTthe view channel perms (turning0b0010into0b1101) - I
ANDthe result with the default perms so0b0111 & 01101which results in0b0101
I'm not sure, although I wouldn't be surprised if there are some helper functions, particularly under PermissionBitField that could allow me to refactor this. Considering that bitwise stuff isn't as common in the mainstream JS world, do you think I should refactor this to potentially use that? Or should I add a comment with the explanation?
There was a problem hiding this comment.
Ah nice thanks for explaining it to me! should defo spruce up my discord bot knowledge been a few years
package.json
Outdated
There was a problem hiding this comment.
⬆️ updated all packages to latest except for eslint because that's going to be a chore until @ljosberinn updates his config (nudge nudge 👀)
I'd go further and advice against going to eslint 9 alot of the community (plugins / configs) haven't migrated yet and the compatibility layer for eslint 8 in eslint 9 is almost zero existent, I tried to do this internally at my work a month ago and fell flat on my ass in every corner. so just to save you both time haha I'd wait it out a little longer.
There was a problem hiding this comment.
I upgraded my workplace eslint plugin to 9 fairly recently so I'm aware of how painful it is 😅, it's kinda why I'm aiming to wait for when gerrit updates his config so he can do all the hard work, seeing as we're using the config anyway.
There's no rush though. I did it because I wanted to use the new using keyword at work which would break our outdated ESLint, and that we're doing a considerable cleanup of our work codebase anyway.
There was a problem hiding this comment.
I won't have time for the forseeable future to update my lib either, am not sure whether I'll continue maintaining it as I'd have to practically rewrite it...
ts-node, it's dead. removednodemontoo as it's not required anymore