Skip to content

feat: new pop add-to command + pop new pallet add pallet to runtime #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 49 commits into from
Closed

feat: new pop add-to command + pop new pallet add pallet to runtime #492

Show file tree
Hide file tree
Changes from 47 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
d96603c
Add pop-add feature with config-type and runtime-pallet options; Upda…
tsenovilla Sep 30, 2024
3ee92dd
Small bug with config_preludes expansion
tsenovilla Sep 30, 2024
47d4a41
Workaround to preseve non-used declarative macros if rust_writer is used
tsenovilla Oct 1, 2024
caad226
Refactor: pop add runtime-pallet => pop add pallet + it detects if it…
tsenovilla Oct 5, 2024
2168974
Refactor: pop add runtime-pallet => pop add pallet + it detects if it…
tsenovilla Oct 5, 2024
764b9ab
Remake error message if pop add pallet path not valid
tsenovilla Oct 5, 2024
9b78cb4
pop add pallet path argument becomes runtime_path
tsenovilla Oct 5, 2024
37e9fe1
Rust writer functions refactor to make them more correct
tsenovilla Oct 5, 2024
4f07e10
Redo pop add config-type
tsenovilla Oct 6, 2024
521639a
Fmt + clippy
tsenovilla Oct 6, 2024
d0e5027
Add first expand tests
tsenovilla Nov 9, 2024
65beb6e
Add a new type of error to describe something; cannot write runtime i…
tsenovilla Nov 9, 2024
93b5ddc
Test files for expanding runtime macros
tsenovilla Nov 9, 2024
f8c98d5
Macro to reduce add_ast functions in pop_common::rust_writer::expand:…
tsenovilla Nov 9, 2024
83b48a1
Add tests expand runtime add pallet
tsenovilla Nov 9, 2024
dc16a9b
Changing ParameterTypes struct so it uses Ident instead of String
tsenovilla Nov 13, 2024
98eb502
Adding test for expand_runtime_add_impl_block
tsenovilla Nov 13, 2024
63894c8
Add test for expand_runtime_add_impl_block
tsenovilla Nov 13, 2024
318c78b
Refactor: split expand_runtime_add_impl_block test in 3 different tests
tsenovilla Nov 14, 2024
c7f44fc
Add test expand add_use_statement
tsenovilla Nov 17, 2024
ead6477
Finalizing expand tests
tsenovilla Nov 17, 2024
62794a9
Move test builder from expand test to rust writer tests
tsenovilla Dec 19, 2024
4631bad
Refactor rust_writer::parse + add several tests
tsenovilla Dec 19, 2024
343059f
correct find_composite_enum + finish rust_witer::parse tests
tsenovilla Jan 22, 2025
18e4fb0
New way of preserve code to improve performance and UX
tsenovilla Jan 26, 2025
4647bdd
Fix preserver bug
tsenovilla Jan 26, 2025
aca725d
Merge remote main branch
tsenovilla Jan 28, 2025
3b1c003
Improve commands to get a better UX
tsenovilla Jan 28, 2025
7bcbce7
rust writer helpers became rust writer preserver; solve a small bug w…
tsenovilla Jan 30, 2025
740b351
Improving error message
tsenovilla Jan 31, 2025
147e4f0
Finishing pop add-to runtime pallet command; concurrent execution + d…
tsenovilla Feb 1, 2025
86c6c3f
Small fixes
tsenovilla Feb 2, 2025
93c8e1a
pop new pallet adds configs in the appropriate path
tsenovilla Feb 2, 2025
6b2c960
pop add-to pallet detects pallet directory + concurrency
tsenovilla Feb 2, 2025
6471c31
Add rollback + finish preserver
tsenovilla Feb 3, 2025
fb68d99
Integrate functionality from new extern crates; Integration tests
tsenovilla Mar 26, 2025
aa20eb6
Merge main
tsenovilla Mar 26, 2025
9904563
Adding rustls-webpki explicitly to Cargo.toml
tsenovilla Mar 26, 2025
2ff6209
Adding rustls-webpki explicitly to Cargo.toml
tsenovilla Mar 26, 2025
5560343
Pin deranged 0.4.0 => https://github.com/jhpratt/deranged/issues/18
tsenovilla Mar 27, 2025
26c0691
Merge main
tsenovilla Mar 27, 2025
33c9567
Update integration tests for add-to + add them to CI
tsenovilla Mar 27, 2025
90843f5
Move add tests to their respective modules; It's testing the command …
tsenovilla Mar 27, 2025
7530ffc
Assert_cmd has problems finding binary if not integration test; Rever…
tsenovilla Mar 27, 2025
05313e1
Modify construct_runtme add pallet test; unparsing an AST sometimes r…
tsenovilla Mar 27, 2025
5affe2c
Modify construct_runtme add pallet test; unparsing an AST sometimes r…
tsenovilla Mar 27, 2025
0fec7e0
fmt
tsenovilla Mar 27, 2025
19775e5
Bump fs_rollback to 3.0.0 and fix related issue in pop new pallet and…
tsenovilla Apr 1, 2025
c274901
Suggested change
tsenovilla Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,3 +199,43 @@ jobs:

- name: Run integration tests
run: cargo test --no-default-features --features parachain --test parachain

file-writer-integration-tests:
Copy link
Contributor

@chungquantin chungquantin Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why do we need an additional CI job here? Wouldn't it be covered by other integration tests CI?

Copy link
Collaborator

@AlexD10S AlexD10S Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently not covered in parachain-integration-tests because we have cargo test --no-default-features --features parachain --test parachain. But definitely easier to just add it there (https://github.com/r0gue-io/pop-cli/blob/main/.github/workflows/ci.yml#L201) than having a whole new job:

run: |
    cargo test --no-default-features --features parachain --test parachain
    cargo test --no-default-features --features parachain --test new_pallet_added_to_existing_runtime
    cargo test --no-default-features --features parachain --test pop_add_to_pallet_config_type
    cargo test --no-default-features --features parachain --test pop_add_to_runtime_pallet

needs: lint
strategy:
matrix:
os: ["ubuntu-latest", "macos-latest"]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Install stable toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
default: true
target: wasm32-unknown-unknown
components: rust-src, clippy

- name: Cache
uses: Swatinem/rust-cache@v2

- name: Install packages (Linux)
if: matrix.os == 'ubuntu-latest'
uses: "./.github/actions/init"
with:
git-user: ${{ env.GITHUB_ACTOR }}

- name: Install packages (macOS)
if: matrix.os == 'macos-latest'
run: |
brew install protobuf
protoc --version

- name: Run integration tests
run: |
cargo test --test pop_add_to_pallet_config_type && \
cargo test --test pop_add_to_runtime_pallet && \
cargo test --test new_pallet_added_to_existing_runtime
Loading
Loading