-
Notifications
You must be signed in to change notification settings - Fork 36
feat: new command pop add pallet
#524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tsenovilla
wants to merge
42
commits into
r0gue-io:main
Choose a base branch
from
tsenovilla:feat/pop-add-pallet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
cdb93bc
Create writer helpers
tsenovilla ee2ad02
Merge branch 'main' into feat/pop-add-pallet
tsenovilla 97c3135
Bring pop add pallet to the branch
tsenovilla 2b23afa
Finishing pop add pallet command + tests
tsenovilla 047f6ba
Merge conflicts
tsenovilla 46877a4
Merge dependencies
tsenovilla 12578da
Add use statements to test
tsenovilla 1c0e66f
Fix clippy
tsenovilla 9c53e83
fmt
tsenovilla edbb1ba
Fix test
tsenovilla 149f21d
Fix test
tsenovilla 515b2e9
Fix parachain test
tsenovilla 76f624d
Fix test
tsenovilla 1104a2c
fix test parachain
tsenovilla 5b020dd
Parachain test compiles pallet contracts version 39.0.0
tsenovilla 7bc09e2
pop add pallet adds pallet features to runtime manifest
tsenovilla d1d8588
Adding missing imports
tsenovilla 54b0a5e
Fix typo
tsenovilla 1be64fa
fmt
tsenovilla f1eb03d
Fmt
tsenovilla 995435c
Fix test
tsenovilla a2c36d9
Fix test
tsenovilla 63661ec
Fix tests
tsenovilla 0c89448
Fixing version issue compatibility in parachain test
tsenovilla a9bbec1
Update crates/pop-cli/tests/parachain.rs
tsenovilla be74757
Update crates/pop-common/src/manifest.rs
tsenovilla 2656010
Update crates/pop-cli/src/commands/add/pallet/common_pallets.rs
tsenovilla 8228181
Update crates/pop-cli/src/commands/add/pallet/common_pallets.rs
tsenovilla ec83aaf
Update crates/pop-cli/src/commands/add/pallet/common_pallets.rs
tsenovilla 3f002e9
Addressing Alex's suggestions
tsenovilla f5ba569
writer compiles only in parachain feature
tsenovilla 037bb0b
chore: add assets pallet
AlexD10S ec5399d
feat: add revive config
AlexD10S ec1c27e
feat: add utility pallet
AlexD10S 3a4b95d
feat: add sudo pallet
AlexD10S 4ae66e0
Merge pull request #4 from tsenovilla/feat/new-pallets
tsenovilla 8cc5bd8
merge main branch
tsenovilla 97c41c4
Remove pending HEAD line
tsenovilla 2700680
fmt
tsenovilla 7fc818d
Using directly release tags from the polkadot sdk rather than pallet …
tsenovilla 0cbf56f
Adding experimental flag
tsenovilla d0b0620
Address test bug
tsenovilla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // SPDX-License-Identifier: GPL-3.0 | ||
|
|
||
| use clap::{Args, Subcommand}; | ||
|
|
||
| pub mod pallet; | ||
|
|
||
| /// Arguments for adding a new feature to existing code | ||
| #[derive(Args)] | ||
| #[command(args_conflicts_with_subcommands = true)] | ||
| pub struct AddArgs { | ||
| #[command(subcommand)] | ||
| pub command: Command, | ||
| } | ||
|
|
||
| #[derive(Subcommand, Debug)] | ||
| pub enum Command { | ||
| /// Add a new pallet to an existing runtime | ||
| #[clap(alias = "P")] | ||
| Pallet(pallet::AddPalletCommand), | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.