- 
                Notifications
    You must be signed in to change notification settings 
- Fork 36
fix: pop call with composite types #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report❌ Patch coverage is  
 @@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   76.89%   77.06%   +0.16%     
==========================================
  Files         109      109              
  Lines       24635    24667      +32     
  Branches    24635    24667      +32     
==========================================
+ Hits        18944    19010      +66     
+ Misses       3702     3654      -48     
- Partials     1989     2003      +14     
 ... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
 | 
0b1578b    to
    8f662d8      
    Compare
  
    | @AlexD10S there's still an edge case: if the second parameter is not specified, it does not return anything. I believe this is expected, as the key is composite. Actually, polkadotjs does not return anything either. But of course this is subject to further discussion. | 
673393e    to
    d2fa86f      
    Compare
  
    513c9e7    to
    9108ff9      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!! Thanks for fixing this
Closes #689.
This PR allows to properly query keys with composed types by transforming them into tuples.
You can test it out by running:
OR
OR
OR
And manually typing 1000 and 4566 as parameters.
Since I was on it, I also:
--skip-confirmflag, which is more specific.--skip-confirmindisplay().