refactor: messaging #587
Open
refactor: messaging #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builds on rust stable
Also bumps other deps in line with versions defined within the stable2506 release.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
156
to
168
| needs: lint | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| RUSTFLAGS: '--cfg ink_abi="all"' | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: "./.github/actions/init" | ||
|
|
||
| - name: Run integration tests | ||
| working-directory: pop-api/integration-tests | ||
| run: cargo test --release --features devnet | ||
| - name: Run API integration tests | ||
| run: cargo test -p pop-api-vnext-integration-tests --release --locked | ||
|
|
||
| api-integration-tests-testnet: | ||
| api-tests: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To fix the problem, add an explicit permissions block to the api-vnext-integration-tests job in .github/workflows/ci.yml. The minimal required permission for most test jobs is contents: read, which allows the job to check out code but not modify repository contents or perform write operations. This change should be made by inserting the following lines under the runs-on: ubuntu-latest line (line 157), before any other keys such as env or steps. No additional methods, imports, or definitions are needed.
Suggested changeset
1
.github/workflows/ci.yml
| @@ -155,6 +155,8 @@ | ||
| api-vnext-integration-tests: | ||
| needs: lint | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| env: | ||
| RUSTFLAGS: '--cfg ink_abi="all"' | ||
| steps: |
Copilot is powered by AI and may make mistakes. Always verify output.
Daanvdplas
changed the base branch from
feat/messaging
to
messaging-precompiles
Base automatically changed from
messaging-precompiles
to
fungibles-precompiles
August 26, 2025 07:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.