credentials error message#117
Open
mkofahl wants to merge 1 commit intor3-team:mainfrom
Open
Conversation
Member
|
Thank you for your effort, though I cannot merge this pull request as is. While failed authentication due to bad credentials is one reason, it is not the only one that blocks access to the system and generates this state on the login page. Some examples are: Issues with communicating with an OpenID provider, not being able to reach a LDAP service and not being allowed to login due to the maintenance mode being active. If we´d want to display a message here, we would have to work out the reason and then display an appropriate message. Since all of these cases result in the same state - ie. user cannot login and cannot do anything about it - we decided not to show a message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show a text message if login credentials are incorrect.