Skip to content

Fix for release build failure #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Fix for release build failure #176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89ec245
Fix for release build failure
ra1028 Mar 26, 2025
6895d8e
Fix flaky tests
ra1028 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 23 additions & 25 deletions Sources/Atoms/Core/StoreContext.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,33 +306,29 @@ private extension StoreContext {
updatedScopes[currentScope.key] = currentScope
}

// Performs update of the given atom with the dependency's context.
func performUpdate(for key: AtomKey, cache: some AtomCacheProtocol, dependency: some Atom) {
dependency.producer.performUpdate {
// Dependents must be updated with the scope at which they were initialised.
let localContext = StoreContext(
store: store,
rootScope: rootScope,
currentScope: cache.initializedScope
)

let didUpdate = localContext.transitiveUpdate(for: key, cache: cache)

guard didUpdate else {
// Record the atom to avoid downstream from being update.
skippedDependencies.insert(key)
return
}
func transitiveUpdate(for key: AtomKey, cache: some AtomCacheProtocol) {
// Dependents must be updated with the scope at which they were initialised.
let localContext = StoreContext(
store: store,
rootScope: rootScope,
currentScope: cache.initializedScope
)

if let scope = cache.initializedScope {
updatedScopes[scope.key] = scope
}
let didUpdate = localContext.transitiveUpdate(for: key, cache: cache)

guard didUpdate else {
// Record the atom to avoid downstream from being update.
skippedDependencies.insert(key)
return
}

if let scope = cache.initializedScope {
updatedScopes[scope.key] = scope
}
}

// Performs update of the given subscription with the dependency's context.
func performUpdate(subscription: Subscription, dependency: some Atom) {
dependency.producer.performUpdate(subscription.update)
func performUpdate(dependency: some Atom, body: @MainActor () -> Void) {
dependency.producer.performUpdate(body)
}

func validEdge(_ edge: Edge) -> Edge? {
Expand Down Expand Up @@ -365,7 +361,9 @@ private extension StoreContext {
let dependencyCache = store.state.caches[edge.from]

if let cache, let dependencyCache {
performUpdate(for: key, cache: cache, dependency: dependencyCache.atom)
performUpdate(dependency: dependencyCache.atom) {
transitiveUpdate(for: key, cache: cache)
}
}

case .subscriber(let key):
Expand All @@ -377,7 +375,7 @@ private extension StoreContext {
let dependencyCache = store.state.caches[edge.from]

if let subscription, let dependencyCache {
performUpdate(subscription: subscription, dependency: dependencyCache.atom)
performUpdate(dependency: dependencyCache.atom, body: subscription.update)
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ while [[ $# -gt 0 ]]; do
esac
done

eval xcodebuild clean test "${options[@]-}" "${args[@]-}"
eval xcodebuild clean test -configuration Release ENABLE_TESTABILITY=YES "${options[@]-}" "${args[@]-}"
Loading