Ra v3 #494
Draft
Ra v3 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
v3
branch
2 times, most recently
from
dbb90ff to
08610a0
Compare
kjnilsson
force-pushed
the
v3
branch
2 times, most recently
from
70b7e6e to
3e50dd2
Compare
kjnilsson
force-pushed
the
v3
branch
5 times, most recently
from
f8a3bed to
177855c
Compare
Responsibilities: * Writing snapshots * Writing and promoting checkpoints * Compaction
To allow machines to report which indexes should be kept in addition to the snapshot. These are written to a new file in the snapshots directory for easy recovery without having to recover the entire snapshot. Other API changes and refactoring.
These have not proved useful o_sync perform very badly and sync_after_notify only provides benefit when there is hardly any activity. It is better to settle for a more predictable mode like the default write + sync provides.
In particular the segment writer and the wal name was provided twice, once in the wal conf and once in the system names map. Also improve WAL log messages to include the system name.
Instead of working off the snapshot index to reduce writes to WAL and segments there is a new "smallest index" that needs to be populated. For normal snapshotting machines this will be snapshot index + 1 but when a machine reportst live indexes it will be the smallest of those.
Most things work now. Instead of passing ranges around we now pass ra_seq instances which is a compacted sequence of items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for visibility of v3 work.
See: https://github.com/rabbitmq/ra/milestone/7