Skip to content

Conversation

@patriktiain
Copy link

@patriktiain patriktiain commented Dec 9, 2025

Proposed Changes

Change from Threading.Channel.Complete() to TryComplete() to catch any race conditions. Race condition can occur if another thread already have called complete on this channel.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

@lukebakken lukebakken self-assigned this Dec 11, 2025
@lukebakken lukebakken self-requested a review December 11, 2025 17:32
@lukebakken lukebakken added this to the 7.2.1 milestone Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants