Skip to content

Conversation

@grahambinns
Copy link

I created this branch because I'm currently working on a project which will use this library, but which has conflicting dependencies.

@grahambinns
Copy link
Author

Missed running clippy — sloppy of me. Will fix that lint and then re-push.

@grahambinns
Copy link
Author

Turns out that running clippy --all-targets opened quite the worm-can 🙃 . I've addressed all of the lints it threw up for the sake of making sure no-one else trips over them in future.

@grahambinns grahambinns force-pushed the update-dependencies branch 2 times, most recently from 399816d to 26ac2ed Compare October 30, 2025 12:12
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.77%. Comparing base (6a98283) to head (3ef4728).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   89.12%   88.77%   -0.35%     
==========================================
  Files          81       81              
  Lines        7625     7112     -513     
==========================================
- Hits         6796     6314     -482     
+ Misses        829      798      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gsantomaggio
Copy link
Member

@wolf4ood @allevo wdyt?

@grahambinns
Copy link
Author

Thanks for the ✅ @Gsantomaggio.

It looks like codecov has bumped on the fact that some lines have been removed — which is detailed in the codecov docs. There are a few options there for how we could deal with this, but AIUI the default setup for codecov is for it to adjust the calculation to filter out code removals.

How would you like me to proceed with addressing the codecov/project failure?

@Gsantomaggio
Copy link
Member

How would you like me to proceed with addressing the codecov/project failure?

yes please but I would do that in another PR.

Thank you for your time @grahambinns

Copy link
Collaborator

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gsantomaggio
Copy link
Member

@grahambinns Our company did some changes around open source contribution, and now it's required that you sign a contributor license agreement (CLA) before we can accept your PR.

The process is explained here in this repo README: https://github.com/rabbitmq/cla

Would you review and sign this CLA?

Then we can merge! Thanks @grahambinns

@grahambinns
Copy link
Author

@Gsantomaggio Sure, that's no problem. I'll take care of that today and let you know when it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants