-
Notifications
You must be signed in to change notification settings - Fork 22
Upgrade all dependencies where doing so wouldn't cause breaking changes. #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fcf2338 to
99c706a
Compare
|
Missed running clippy — sloppy of me. Will fix that lint and then re-push. |
|
Turns out that running |
399816d to
26ac2ed
Compare
26ac2ed to
3ef4728
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 89.12% 88.77% -0.35%
==========================================
Files 81 81
Lines 7625 7112 -513
==========================================
- Hits 6796 6314 -482
+ Misses 829 798 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the ✅ @Gsantomaggio. It looks like codecov has bumped on the fact that some lines have been removed — which is detailed in the codecov docs. There are a few options there for how we could deal with this, but AIUI the default setup for codecov is for it to adjust the calculation to filter out code removals. How would you like me to proceed with addressing the codecov/project failure? |
yes please but I would do that in another PR. Thank you for your time @grahambinns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@grahambinns Our company did some changes around open source contribution, and now it's required that you sign a contributor license agreement (CLA) before we can accept your PR. The process is explained here in this repo README: https://github.com/rabbitmq/cla Would you review and sign this CLA? Then we can merge! Thanks @grahambinns |
|
@Gsantomaggio Sure, that's no problem. I'll take care of that today and let you know when it's done. |
I created this branch because I'm currently working on a project which will use this library, but which has conflicting dependencies.