Conversation
kngwyu
left a comment
There was a problem hiding this comment.
Thanks, I'll fix these tests later.
|
Should we block releasing 2.1.41 on fixed tests? |
|
@Xanewok |
@calebcartwright this was probably caused by not having rust-src component - that's what I'm seeing locally after introducing the # rust-toolchain
[toolchain]
channel = "nightly-2020-11-27"
components = ["rust-src"]After installing this locally, now only |
|
Running the test with There's a good chance that rust-lang/rust#78461 broke the test - it seems that inline attribute on a generic parameter is not recognized, i.e. |
|
Thanks! |
We have another broken toolstate issue with RLS and rustfmt that requires bumping the rustc-ap crates to the latest version.
I am getting one test failure in my local environment even after these changes, but I was getting five test failures with the latest on master so I'm guessing this is unrelated
Refs rust-lang/rust#79406 and rust-lang/rust#79407
r? @kngwyu and/or @Xanewok