Conversation
Collaborator
Author
|
I believe the action will be only triggered and run once it's committed to stop potentially malicious actors from extracting CI secrets and so on via PRs. |
Xanewok
force-pushed
the
github-actions
branch
from
960ad62 to
4f77d36
Compare
kngwyu
approved these changes
Dec 4, 2020
Collaborator
kngwyu
left a comment
kngwyu
left a comment
There was a problem hiding this comment.
Thanks!
Could please also remove .appveyor.yml?
Since now we run tests for Windows on actions, it is no longer useful.
| - master | ||
| - '*' | ||
| schedule: | ||
| - cron: '0 0 * * *' # Nightly at 00:00 UTC |
Collaborator
There was a problem hiding this comment.
Nice 👍 (as our build is often broken 😅
Collaborator
Author
Done. |
Collaborator
Yeah, but let's remove it after watching the actions work. Thanks! |
This was referenced Dec 4, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1144 (now merged) so that the tests pass.
Fixes #1145
The spin-up time is very fast and a single build runs 3-5 minutes (all 4 builds run in parallel), and so that's an improvement over what we have: AppVeyor runs 5-7 mins, Travis runs 15-20 mins (but needs some time to spin up). This also adds testing for macOS.
See https://github.com/Xanewok/racer/actions/runs/396511445 for a successful run.
r? @kngwyu