Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore-skip flag #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheZoq2
Copy link
Contributor

@TheZoq2 TheZoq2 commented Aug 17, 2023

I have some long running tests which download files. I want to test them in CI but don't feel like remembering to add the -e flag every time I run runt

My initial idea was to add a exclude_by_default toml flag which would only run the tests if -i was used, but then you need to -i all tests which is also not what I want

This skip solution works for my use though it does feel like a bit of a hack

@rachitnigam
Copy link
Owner

Oh interesting! This is a bit funky because it'd require you to have both the .skip and .expect around for the same test. One style thing we use in our existing runt files (like the one for Calyx) is adding fake "tags" like "correctness" or "frontend" and then saying something like:

runt -i correctness

One possible workaround for your suite might be having such tags. It might be good to add a formal mechanism for those tags in runt as well.

@TheZoq2
Copy link
Contributor Author

TheZoq2 commented Aug 17, 2023

Oh interesting! This is a bit funky because it'd require you to have both the .skip and .expect around for the same test.
This doesn't seem super weird to me, for example if I have a test that worked before, but I've now temporarily broken but still want to keep the old goldentest around, I would end up with .expect and .skip

Of course, in that situation, my --ignore-skip isn't very heplful though 😓

Tags would kind of solve the issue, but as far as I can tell, there is no mechanism to have a default set of tags, or to run all tests? Or have I missed some flag somewhere?

@rachitnigam
Copy link
Owner

You have not! Tags are entirely a naming discipline in runt and don’t really exist in any other form right now. Regarding your broken golden test example, the workflow we’ve used in the past is to simply rename the expect file to skip and go from there.

@rachitnigam
Copy link
Owner

@TheZoq2 just gauging what you think about the ad-hoc tag nonsense and if the skip-ignore flag still makes sense. If it does, let's merge it.

@TheZoq2
Copy link
Contributor Author

TheZoq2 commented Aug 22, 2023

For my use case, where I want to run all tests apart from long running ones, and explicitly requiring enabling those, it seems like the tag stuff doesn't work.

But using the .skip feature for that also feels like a bit of a hack imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants