feat: Adding multiple interfaces uplink on the vSwitch #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you build an image with this rebased and test it? |
skrobul
reviewed
Jun 25, 2025
Comment on lines
105
to
111
| uplink_nics = [] | ||
| for network in eligible_networks: | ||
| link = network.link | ||
| nic = self.nics.find_by_mac(link.ethernet_mac_address) | ||
| uplink_nics.append(nic) | ||
|
|
||
| return uplink_nics |
There was a problem hiding this comment.
Suggested change
| uplink_nics = [] | |
| for network in eligible_networks: | |
| link = network.link | |
| nic = self.nics.find_by_mac(link.ethernet_mac_address) | |
| uplink_nics.append(nic) | |
| return uplink_nics | |
| return [self.nics.find_by_mac(n.link.ethernet_mac_address) for n in eligible_networks ] |
haseebsyed12
force-pushed
the
multi_uplinks
branch
from
ff468a1 to
f2c9193
Compare
haseebsyed12
force-pushed
the
multi_uplinks
branch
from
f2c9193 to
46a9eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix this limitation #16