Skip to content

Conversation

@reet8598
Copy link
Contributor

Objective - Separate skyline secret creation from create-secrets.sh to create-skyline-secrets.sh and Update openstack-skyline.md docs

@reet8598 reet8598 self-assigned this Oct 28, 2025
@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨

1 similar comment
@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨

Copy link
Contributor

@rackerchris rackerchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add skylinesecrets.yaml to .gitignore

@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨

@reet8598 reet8598 requested a review from rackerchris October 30, 2025 16:10
Copy link
Contributor

@rackerchris rackerchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Copy link
Contributor

@cloudnull cloudnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @rackerchris to approve.

@reet8598 reet8598 force-pushed the ospc-1566/skyline-secret-updation branch from bbef35c to e74df38 Compare October 31, 2025 06:30
@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨

@reet8598 reet8598 force-pushed the ospc-1566/skyline-secret-updation branch from e74df38 to 29b74f0 Compare October 31, 2025 08:07
@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨

@reet8598 reet8598 force-pushed the ospc-1566/skyline-secret-updation branch from 29b74f0 to d7001fb Compare October 31, 2025 08:10
@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨

@rackerchris rackerchris merged commit dde13a6 into rackerlabs:main Oct 31, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants