-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Nova compute driver with storage network IP injection #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
695eac1
to
c8cad09
Compare
16836b3
to
ce40876
Compare
ce40876
to
761ffde
Compare
cardoe
reviewed
Oct 7, 2025
nova driver must live under nova.virt. It cannot be external to the nova project because of this: https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/virt/driver.py#L2074
Rather than trying to intercept and rewrite whole spawn() method, we should be able to override only the _get_network_metadata(). It's better this way because it's much smaller and it's also used inside the rebuild() which we'd have to override too.
In case we need to run other playbooks...
Rather than hardcoding 100.127.0.0/16, we should use side-specific routes so both sides can be reached independently.
Running this again would be redundant since this is already triggered in Nova (see previous commit)
Openstack uses format without dashes, Nautobot expects one with dashes.
This way our modified code is almost all in separate method and it's clear what has been changed.
This way our modified code is almost all in separate method and it's clear what has been changed.
761ffde
to
ab35ff1
Compare
cardoe
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a custom Nova compute driver that automatically injects storage network configuration into instance config drives when requested.
Key Changes
IronicUnderstackDriver
: Extends Nova's standard Ironic driver to support storage network injectionstorage=wanted
property and the project is enabled forUNDERSTACK_SVM
).How it works
When an instance has
metadata.storage=wanted
, the driver:Below (simplified) diagram shows how the components interact to make this feature work:
Configuration
Most of the configuration is under
[nova_understack]
section of thenova-compute-ironic
.ip_injection_enabled=False
ansible_playbook_filename
- this can come handy if we decide to cleanup.yml
extensions and name them correctly with.yaml
.Closes https://rackspace.atlassian.net/browse/PUC-1242
Depends on https://github.com/RSS-Engineering/undercloud-deploy/pull/771
Notes for the reviewer
If reviewing commit-by-commit, please start from c1d22b6 as the earlier commit have been reverted in f9cb501. I have purposefully included them in PR so that Ironic custom hardware manager experiment is recorded in history if we ever want to create something similar.
I have at least one idea where this may become useful, so don't want to just throw it out.