Automated Resyntax fixes #718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
…t-lambda` The lambda can be removed from the failure result in this `hash-ref` expression.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This method chain made of nested `send` expressions can be written more clearly as a `send+` expression.
This `if`-`else` chain can be converted to a `cond` expression.
Using `cond` instead of `if` here makes `begin` unnecessary
This expression is equivalent to calling the `positive?` predicate.
rfindler
reviewed
Feb 16, 2025
| (let ([y (node-y (node-parent p))]) | ||
| (if (and y (eq? 'red (node-color y))) | ||
| (recolor-k y) | ||
| (let ([k (lambda (node) | ||
| (rotate-k always-rotate node))]) | ||
| (let ([k (lambda (node) (rotate-k always-rotate node))]) | ||
| (if (eq? node (node-y p)) |
There was a problem hiding this comment.
In this region (recolor-k, rotate-k, and k), why didn't the lets turn into defines? It looks like the main change here is reformatting?
rfindler
reviewed
Feb 16, 2025
| (cond | ||
| [(<= pos npos) (loop (node-left n) n npos v)] | ||
| [(or (not so-far-pos) (> npos so-far-pos)) (loop (node-right n) n npos npos)] | ||
| [else (loop (node-right n) so-far so-far-pos npos)]))))) |
There was a problem hiding this comment.
the formatting changes here don't seem like a win, alas.
rfindler
reviewed
Feb 16, 2025
| (define b (send dc get-brush)) | ||
| (send | ||
| dc | ||
| set-brush |
There was a problem hiding this comment.
another send formatting issue. I think this one has been mentioned before, tho.
|
Other than the comments above, I think this is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 5 files.
let-to-definesend-chain-to-send+if-begin-to-condnested-if-to-condcond-let-to-cond-definehash-ref-with-constant-lambda-to-hash-ref-without-lambdazero-comparison-to-positive?if-let-to-cond