Automated Resyntax fixes #1433
Open
Automated Resyntax fixes #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
The `null?` predicate can be used to test for the empty list.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This negated `when` expression can be replaced by an `unless` expression.
This `if` expression can be refactored to an equivalent expression using `and`.
Providing the same identifier multiple times is unnecessary.
The `syntax-disarm` function is a legacy function that does nothing.
This `match` expression can be simplified using `match-define`.
The `define` form supports a shorthand for defining functions.
Only one of the `for/fold` expression's result values is used. Use the `#:result` keyword to return just that result.
The `append-map` function can be used to map each element into multiple elements in a single pass.
The `else`-`if` branch of this `cond` expression can be collapsed into the `cond` expression.
This use of `define-values` is unnecessary.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This quasiquotation is equialent to a simple `list` call.
This `if` expression can be refactored to an equivalent expression using `and`.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if`-`else` chain can be converted to a `cond` expression.
This `let` expression can be pulled up into a `define` expression.
samth
reviewed
Feb 7, 2025
| @@ -99,7 +99,8 @@ | |||
| (struct m (x)) | |||
| (define val (m 1)) | |||
|
|
|||
| (define thunk (λ () 1)) | |||
| (define (thunk) | |||
samth
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 20 files.
let-to-definesingle-clause-match-to-match-definecond-let-to-cond-definedefine-lambda-to-defineif-else-false-to-andnested-if-to-condmap-to-forcond-else-if-to-condquasiquote-to-listdefine-simple-macro-to-define-syntax-parse-ruledefine-values-values-to-defineappend*-and-map-to-append-mapprovide-deduplicationfor/fold-result-keyworddefine-let-to-double-defineequal-null-list-to-null-predicatealways-throwing-if-to-wheninverted-whensyntax-disarm-migration