Automated Resyntax fixes #1434
Open
Automated Resyntax fixes #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This `match` expression can be simplified using `match-define`.
This use of `format` does nothing.
Using `cond` instead of `if` here makes `begin` unnecessary
This conditional expression can be replaced with a simpler, equivalent expression.
The `begin0` in this definition can be extracted into the surrounding definition context.
The `define` form supports a shorthand for defining functions.
This `map` operation can be replaced with a `for/list` loop.
The `syntax-disarm` function is a legacy function that does nothing.
This expression is equivalent to calling the `positive?` predicate.
This use of `define-values` is unnecessary.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
This `and` expression can be turned into a clause of the inner `match` expression, reducing nesting.
This `begin` form can be flattened into the surrounding definition context.
This negated `when` expression can be replaced by an `unless` expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 19 files.
single-clause-match-to-match-definedefine-lambda-to-definelet-to-definezero-comparison-to-positive?define-values-values-to-defineif-begin-to-condsyntax-disarm-migrationif-x-else-x-to-andformat-identityif-let-to-condwhen-expression-in-for-loop-to-when-keyworddefine-begin0-extractioninverted-whenmap-to-forunless-expression-in-for-loop-to-unless-keywordand-match-to-matchinline-unnecessary-begin