Return null on empty json string in PHP7 #712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP7 uses the JSOND extension for parsing JSON which now throws an error on an empty string. The JSON response is checked whether it is empty before decoding it and returns null for backwards compatibility.
thomaslorentsen
changed the title
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP7 no longer considers an empty string as valid JSON.
When passing an empty string to
json_decodean exception is raised instead of returningnull.This is documented on the PHP7 Backward incompatible changes page.
I have updated the method to check for an empty response string and return
nullinstead.