This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
[WIP - Don't close] Travis workaround #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example output of this subcommand (one keypair with the name vagrant is available on Rackspace Servers): ``` $ vagrant rackspace keypairs ==> default: KeyPair Name ==> default: vagrant ```
Example output of this subcommand: ``` $ vagrant rackspace networks ==> default: Network Name Network CIDR ==> default: private ==> default: public ==> default: vagrant001 192.168.3.0/24 ==> default: vagrant002 192.168.4.0/24 ==> default: vagrant003 192.168.5.0/24 ```
Example output of this subcommand: ``` $ vagrant rackspace servers ==> devstack: Server Name State IPv4 address ==> devstack: devstack ACTIVE 166.78.18.8 ```
``` ==> devstack: Network Name Network CIDR Network ID ==> devstack: private 11111111-1111-1111-1111-111111111111 ==> devstack: public 00000000-0000-0000-0000-000000000000 ==> devstack: vagrant001 192.168.3.0/24 c7da5d07-ac80-49ca-8575-8822c71bc758 ==> devstack: vagrant002 192.168.4.0/24 f45ba323-dd21-4999-a5d7-c98a3edfb7a3 ==> devstack: vagrant003 192.168.5.0/24 e49a86df-6c98-42d1-a66b-11c80e1252e1 ```
This pull request implements a fix for #114
Confirm Rackspace server destruction.
Confirm Rackspace server destruction.
Fix uninitialized constant error.
added subcommand keypairs to list SSH key pairs
…-rackspace into berendt-subcommand_list_networks
Conflicts: lib/vagrant-rackspace/action.rb lib/vagrant-rackspace/command/root.rb
…rackspace into berendt-subcommand_list_servers Conflicts: lib/vagrant-rackspace/action.rb lib/vagrant-rackspace/command/root.rb
rewrote the custom commands section
Support for pre-configuring communicator transports (SSH or WinRM) via init_script setting
Winrm msgs
Set box_optional and parallel attributes
| module Rackspace | ||
| module Action | ||
| class ListKeyPairs | ||
| def initialize(app, env) |
There was a problem hiding this comment.
Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
This key is required to do just about anything with the Rackspace API. :D
Add `rackspace_region` configuration to sample config
Some of us are less proficient in ruby, and it took me a while
to figure out how to read my environment variable from the vagrant
file. I'm a bit wiser for this, and hopefuly it will save someone
a bit of time.
Hopefuly, also, it will prevent a couple of publicly spilled
api keys...
Changes to be committed:
modified: README.md
Also, added missing quotes on previous environment example.
gotta get in this ruby thing.. =)
Changes to be committed:
modified: README.md
Clarified README.md about setting up and sourcing env variables for best practice of keeping api keys private
| @@ -39,7 +40,8 @@ | |||
| :server_name, | |||
| :disk_config, | |||
| :username, | |||
| :admin_password].each do |attribute| | |||
| :admin_password, | |||
There was a problem hiding this comment.
Align the elements of an array literal if they span more than one line.
Update README.md
| end | ||
|
|
||
| argv = parse_options(opts) | ||
| return if !argv |
There was a problem hiding this comment.
Favor unless over if for negative conditions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ha - I'm smart. Since the Travis hook isn't enabled for mitchellh/vagrant-rackspace, we can setup a PR from that fork to this one.
This PR will keep building every time something is merged to mitchellh:master. So we won't have builds for PRs, but we'll at least have travis running after the PR is merged.