feat(unique): let toKey return any kind of value (#10)

* fix(unique): support any value

…instead of only values that can be identified through a key or can be used as keys themselves.

* test: add a test

Thanks to @jordydhoker for contributing this test: sodiray/radash#343

* fix(unique): skip `reduce` call if `toKey` is not defined

Co-authored-by: jordydhoker <[email protected]>

src/array/tests/unique.test.ts

@@ -23,4 +23,24 @@ describe('unique function', () => {
     expect(c.id).toBe('c')
     expect(c.word).toBe('yolo')
   })
+  test('correctly handles non string, number or symbol values', () => {
+    const list: any[] = [
+      null,
+      null,
+      true,
+      true,
+      'true',
+      false,
+      { id: 'a', word: 'hello' },
+      { id: 'a', word: 'hello' }
+    ]
+    const result = _.unique(list, val => (val && val.id) ?? val)
+    expect(result).toEqual([
+      null,
+      true,
+      'true',
+      false,
+      { id: 'a', word: 'hello' }
+    ])
+  })
 })

src/array/unique.ts

@@ -3,15 +3,20 @@
  * Accepts an optional identity function to convert each item in the
  * list to a comparable identity value
  */
-export const unique = <T, K extends string | number | symbol>(
+export const unique = <T, K = T>(
   array: readonly T[],
   toKey?: (item: T) => K
 ): T[] => {
-  const valueMap = array.reduce((acc, item) => {
-    const key = toKey ? toKey(item) : (item as any as string | number | symbol)
-    if (acc[key]) return acc
-    acc[key] = item
-    return acc
-  }, {} as Record<string | number | symbol, T>)
-  return Object.values(valueMap)
+  if (toKey) {
+    const keys = new Set<K>()
+    return array.reduce((acc, item) => {
+      const key = toKey(item)
+      if (!keys.has(key)) {
+        keys.add(key)
+        acc.push(item)
+      }
+      return acc
+    }, [] as T[])
+  }
+  return [...new Set(array)]
 }