Skip to content

Resolve formatter executable commands prior to calling them#341

Merged
raxod502 merged 3 commits intoradian-software:mainfrom
tylerjl:path-executable
Feb 7, 2025
Merged

Resolve formatter executable commands prior to calling them#341
raxod502 merged 3 commits intoradian-software:mainfrom
tylerjl:path-executable

Conversation

@tylerjl
Copy link
Copy Markdown
Contributor

@tylerjl tylerjl commented Jan 18, 2025

Hi! Thanks for your work on apheleia, it's great.

An issue I've run into recently is that sometimes my remote executables aren't immediately in-$PATH: I need to resolve them via executable-find - which does find them - before invoking the process. This should be safe, given that the step is performed at a prior step. I'm overwriting the command variable since I infer that the executable name is being reused later when you're matching a callback, I think?

I mentioned that executable-find happens earlier in the call chain so I could maybe improve this by removing that and only resolving the executable once, but I wanted to check in with you to determine whether the overall problem and solution even make sense to somebody else.

@raxod502
Copy link
Copy Markdown
Member

raxod502 commented Feb 7, 2025

See also: #347

@raxod502
Copy link
Copy Markdown
Member

raxod502 commented Feb 7, 2025

I think this is a workaround to a problem that is better solved elsewhere, but I think it is okay to do this to fix the immediate problem rather than waiting to fix everything.

@raxod502 raxod502 merged commit ba333e7 into radian-software:main Feb 7, 2025
@tylerjl
Copy link
Copy Markdown
Contributor Author

tylerjl commented Feb 7, 2025

Thank you @raxod502, I appreciate it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants