Resolve formatter executable commands prior to calling them#341
Merged
raxod502 merged 3 commits intoradian-software:mainfrom Feb 7, 2025
Merged
Resolve formatter executable commands prior to calling them#341raxod502 merged 3 commits intoradian-software:mainfrom
raxod502 merged 3 commits intoradian-software:mainfrom
Conversation
Member
|
See also: #347 |
Member
|
I think this is a workaround to a problem that is better solved elsewhere, but I think it is okay to do this to fix the immediate problem rather than waiting to fix everything. |
raxod502
approved these changes
Feb 7, 2025
Contributor
Author
|
Thank you @raxod502, I appreciate it 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for your work on apheleia, it's great.
An issue I've run into recently is that sometimes my remote executables aren't immediately in-
$PATH: I need to resolve them viaexecutable-find- which does find them - before invoking the process. This should be safe, given that the step is performed at a prior step. I'm overwriting thecommandvariable since I infer that the executable name is being reused later when you're matching a callback, I think?I mentioned that
executable-findhappens earlier in the call chain so I could maybe improve this by removing that and only resolving the executable once, but I wanted to check in with you to determine whether the overall problem and solution even make sense to somebody else.