Skip to content

release 0.4.0 - #80

Merged
AymenFJA merged 1 commit into
mainfrom
release/v0.4.0
May 18, 2026
Merged

release 0.4.0#80
AymenFJA merged 1 commit into
mainfrom
release/v0.4.0

Conversation

@AymenFJA

Copy link
Copy Markdown
Collaborator

No description provided.

@AymenFJA AymenFJA self-assigned this May 18, 2026
@AymenFJA
AymenFJA merged commit 739716e into main May 18, 2026
12 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG.md to include the release of version 0.4.0. The review feedback identifies critical issues including a TypeError in the data dependency resolution logic when using the local backend, a blocking call in an asynchronous context, and a potential crash on Windows due to the use of signal.SIGUSR1.

Comment thread CHANGELOG.md

## [Unreleased]

## [0.4.0] - 2026-05-18

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The release 0.4.0 contains a critical bug in the data dependency resolution logic. In src/radical/asyncflow/workflow_manager.py at line 1140, the code attempts to access item["target"], where item is the result of self.backend.link_explicit_data_deps. However, in src/radical/asyncflow/backends.py, LocalExecutionBackend.link_explicit_data_deps returns None (line 410), which will cause a TypeError whenever explicit data dependencies are used with the local backend. Additionally, LocalExecutionBackend.shutdown (line 404) performs a blocking call to executor.shutdown(wait=True) within an async context, which will block the event loop.

Comment thread CHANGELOG.md

## [Unreleased]

## [0.4.0] - 2026-05-18

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Please ensure the package version is updated in the project metadata (e.g., pyproject.toml), as src/radical/asyncflow/__init__.py relies on importlib.metadata to report the version. Also, note that the use of signal.SIGUSR1 in workflow_manager.py (line 1256) will cause a crash on Windows, as that signal is not available on that platform. Consider using a more portable approach for internal shutdown signaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant