release 0.4.0 - #80
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md to include the release of version 0.4.0. The review feedback identifies critical issues including a TypeError in the data dependency resolution logic when using the local backend, a blocking call in an asynchronous context, and a potential crash on Windows due to the use of signal.SIGUSR1.
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [0.4.0] - 2026-05-18 |
There was a problem hiding this comment.
The release 0.4.0 contains a critical bug in the data dependency resolution logic. In src/radical/asyncflow/workflow_manager.py at line 1140, the code attempts to access item["target"], where item is the result of self.backend.link_explicit_data_deps. However, in src/radical/asyncflow/backends.py, LocalExecutionBackend.link_explicit_data_deps returns None (line 410), which will cause a TypeError whenever explicit data dependencies are used with the local backend. Additionally, LocalExecutionBackend.shutdown (line 404) performs a blocking call to executor.shutdown(wait=True) within an async context, which will block the event loop.
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [0.4.0] - 2026-05-18 |
There was a problem hiding this comment.
Please ensure the package version is updated in the project metadata (e.g., pyproject.toml), as src/radical/asyncflow/__init__.py relies on importlib.metadata to report the version. Also, note that the use of signal.SIGUSR1 in workflow_manager.py (line 1256) will cause a crash on Windows, as that signal is not available on that platform. Consider using a more portable approach for internal shutdown signaling.
No description provided.